Skip to content

fix(match2): scss broken for dota2 stats header title in matchpage#6607

Closed
ElectricalBoy wants to merge 1 commit intomainfrom
matchpage-scss-fix
Closed

fix(match2): scss broken for dota2 stats header title in matchpage#6607
ElectricalBoy wants to merge 1 commit intomainfrom
matchpage-scss-fix

Conversation

@ElectricalBoy
Copy link
Copy Markdown
Collaborator

@ElectricalBoy ElectricalBoy commented Sep 30, 2025 •
edited
Loading

Summary

Related: #6463

Lua-Modules/stylesheets/commons/BigMatch.scss

Lines 1171 to 1177 in 93b33c5

@at-root html h4#{&}-title {
font-weight: bold;
text-transform: uppercase;
color: var( --clr-on-background ) !important;
margin: 0;
padding: 0;
}

The above scss compiles to the following css in php-scss 1.x:

html h4self-header-title {
    font-weight: bold;
    text-transform: uppercase;
    color: var(--clr-on-background) !important;
    margin: 0;
    padding: 0
}

This PR adjusts the stylesheet to workaround the scss issue.

Note: May become obsolete with Liquipedia/ResourceLoaderArticles#17

How did you test this change?

browser dev tools

@ElectricalBoy ElectricalBoy added c: match2 g: dota2 DOTA2 stylesheets Changes to stylesheets labels Sep 30, 2025
@ElectricalBoy ElectricalBoy changed the title fix(match2): scss broken for dota2 stats header title fix(match2): scss broken for dota2 stats header title in matchpage Sep 30, 2025
@Rathoz
Copy link
Copy Markdown
Collaborator

Rathoz commented Sep 30, 2025

We're likely to push PHP-SCSS 2.0 later this week or early next. Let's wait unless very important

@FO-nTTaX
Copy link
Copy Markdown
Member

FO-nTTaX commented Oct 8, 2025

scssphp2 has been deployed again, so lmk if anything is still broken there

@ElectricalBoy
Copy link
Copy Markdown
Collaborator Author

ElectricalBoy commented Oct 9, 2025

Obsolete with Liquipedia/ResourceLoaderArticles#17

@ElectricalBoy ElectricalBoy deleted the matchpage-scss-fix branch October 9, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rathoz Rathoz Awaiting requested review from Rathoz

Assignees

No one assigned

Labels

c: match2 g: dota2 DOTA2 stylesheets Changes to stylesheets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElectricalBoy @Rathoz @FO-nTTaX